Change in ...coreboot[master]: src/superio/smsc/smscsuperio/superio.c: Add SCH5504 - coreboot-gerrit

14 Jan 2019


      Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28971 )
Change subject: src/superio/smsc/smscsuperio/superio.c: Add SCH5504
......................................................................
Patch Set 3:
...
Patch Set 1: Code-Review+1
looks good to me; I'd like to wait with +2ing this until there is a patch adding mainboard with this superio in the review system though
Tested with dell/gx520, serial port works for logging stuff. The mainboard is not merged yet, however.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/28971
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c433fa04c01ba6315bcdca699030dfce18a169a
Gerrit-Change-Number: 28971
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Christoph Pomaska github@aufmachen.jetzt
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 14 Jan 2019 10:16:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment