Attention is currently required from: Anil Kumar K, Maulik V Vaghela, Paul Menzel, Meera Ravindranath, Sathya Prakash M R, Tim Wawrzynczak, Angel Pons, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51408 )
Change subject: mb/intel/adlrvp: Update Mainboard part number and Vendor
......................................................................
Patch Set 10: Code-Review+2
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51408/comment/fe5ef04a_47b55c50
PS2, Line 7: Update Mainboard vendor
Please mention SMBIOS.
Although `SMBIOS` is not mentioned explicitly, the commit message now mentions the `dmidecode` utility, which is used to dump and decode the DMI/SMBIOS tables.
https://review.coreboot.org/c/coreboot/+/51408/comment/1af5222d_5abd455e
PS2, Line 8:
What is shown right now in the SMBIOS tables? Why does it need to be changed?
Vendor uses the name shown in menuconfig, which is "Intel". As to why it needs to be changed, it is now explained in the commit message.
Patchset:
PS9:
Hi Furquan/Tim/Angel, if you can help reviewing this CL?
Done
File src/mainboard/intel/adlrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/51408/comment/914a38cc_f225ee69
PS7, Line 49: Alder Lake Client Platform
I think so. […]
Any updates?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51408
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7cce423de624e7056e88b52a1443c554fd9123bc
Gerrit-Change-Number: 51408
Gerrit-PatchSet: 10
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 20 Jun 2021 10:36:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anil Kumar K
anil.kumar.k@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-MessageType: comment