Change in coreboot[master]: inteltool: Add Intel 200 and Z370 series chipset

[Iru Cai (vimacs) (Code Review)]

Hello Iru Cai,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/35909

to review the following change.

Change subject: inteltool: Add Intel 200 and Z370 series chipset
......................................................................

inteltool: Add Intel 200 and Z370 series chipset

These chipsets are in the "Intel 200 (including X299) and Intel Z370
Series Chipset Families Platform Controller Hub (PCH)" datasheet
(document number 335192).

Change-Id: I4bad85eebab3991048907e5bd4783ad4e6ffa641
Signed-off-by: Iru Cai 
---
M util/inteltool/gpio.c
M util/inteltool/gpio_groups.c
M util/inteltool/inteltool.c
M util/inteltool/inteltool.h
M util/inteltool/pcr.c
5 files changed, 36 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/35909/1

diff --git a/util/inteltool/gpio.c b/util/inteltool/gpio.c
index efeab56..97e1419 100644
--- a/util/inteltool/gpio.c
+++ b/util/inteltool/gpio.c
@@ -1070,6 +1070,13 @@
    case PCI_DEVICE_ID_INTEL_QM370:
    case PCI_DEVICE_ID_INTEL_HM370:
    case PCI_DEVICE_ID_INTEL_CM246:
+	case PCI_DEVICE_ID_INTEL_Z270:
+	case PCI_DEVICE_ID_INTEL_H270:
+	case PCI_DEVICE_ID_INTEL_B250:
+	case PCI_DEVICE_ID_INTEL_Q250:
+	case PCI_DEVICE_ID_INTEL_Q270:
+	case PCI_DEVICE_ID_INTEL_X299:
+	case PCI_DEVICE_ID_INTEL_Z370:
    	print_gpio_groups(sb);
    	return 0;
    case PCI_DEVICE_ID_INTEL_82371XX:
diff --git a/util/inteltool/gpio_groups.c b/util/inteltool/gpio_groups.c
index 321cf97..d43983d 100644
--- a/util/inteltool/gpio_groups.c
+++ b/util/inteltool/gpio_groups.c
@@ -2239,6 +2239,13 @@
    case PCI_DEVICE_ID_INTEL_QM170:
    case PCI_DEVICE_ID_INTEL_HM170:
    case PCI_DEVICE_ID_INTEL_CM236:
+	case PCI_DEVICE_ID_INTEL_Z270:
+	case PCI_DEVICE_ID_INTEL_H270:
+	case PCI_DEVICE_ID_INTEL_B250:
+	case PCI_DEVICE_ID_INTEL_Q250:
+	case PCI_DEVICE_ID_INTEL_Q270:
+	case PCI_DEVICE_ID_INTEL_X299:
+	case PCI_DEVICE_ID_INTEL_Z370:
    	community_count = ARRAY_SIZE(sunrise_communities);
    	communities = sunrise_communities;
    	pcr_init(sb);
diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c
index db80bd2..8fef3b4 100644
--- a/util/inteltool/inteltool.c
+++ b/util/inteltool/inteltool.c
@@ -275,6 +275,13 @@
    { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C621_SUPER, "C621 Super SKU" },
    { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C627_SUPER_2, "C627 Super SKU" },
    { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C628_SUPER, "C628 Super SKU" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_Z270, "Z270" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_H270, "H270" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_B250, "B250" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_Q250, "Q250" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_Q270, "Q270" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_X299, "X299" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_Z370, "Z370" },
    { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_H310, "H310" },
    { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_H370, "H370" },
    { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_Z390, "Z390" },
diff --git a/util/inteltool/inteltool.h b/util/inteltool/inteltool.h
index fc6dc4b..def78c6 100644
--- a/util/inteltool/inteltool.h
+++ b/util/inteltool/inteltool.h
@@ -184,6 +184,14 @@
 #define PCI_DEVICE_ID_INTEL_C627_SUPER_2	0xa245
 #define PCI_DEVICE_ID_INTEL_C628_SUPER		0xa246

+#define PCI_DEVICE_ID_INTEL_Z270		0xa2c5
+#define PCI_DEVICE_ID_INTEL_H270		0xa2c4
+#define PCI_DEVICE_ID_INTEL_B250		0xa2c8
+#define PCI_DEVICE_ID_INTEL_Q250		0xa2c7
+#define PCI_DEVICE_ID_INTEL_Q270		0xa2c6
+#define PCI_DEVICE_ID_INTEL_X299		0xa2d2
+#define PCI_DEVICE_ID_INTEL_Z370		0xa2c9
+
 #define PCI_DEVICE_ID_INTEL_H310		0xa303
 #define PCI_DEVICE_ID_INTEL_H370		0xa304
 #define PCI_DEVICE_ID_INTEL_Z390		0xa305
diff --git a/util/inteltool/pcr.c b/util/inteltool/pcr.c
index ef6bb39..b6dc5e8 100644
--- a/util/inteltool/pcr.c
+++ b/util/inteltool/pcr.c
@@ -117,6 +117,13 @@
    case PCI_DEVICE_ID_INTEL_C627_SUPER_2:
    case PCI_DEVICE_ID_INTEL_C628_SUPER:
    case PCI_DEVICE_ID_INTEL_DNV_LPC:
+	case PCI_DEVICE_ID_INTEL_Z270:
+	case PCI_DEVICE_ID_INTEL_H270:
+	case PCI_DEVICE_ID_INTEL_B250:
+	case PCI_DEVICE_ID_INTEL_Q250:
+	case PCI_DEVICE_ID_INTEL_Q270:
+	case PCI_DEVICE_ID_INTEL_X299:
+	case PCI_DEVICE_ID_INTEL_Z370:
    	p2sb = pci_get_dev(sb->access, 0, 0, 0x1f, 1);
    	break;
    case PCI_DEVICE_ID_INTEL_APL_LPC:

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35909 )

Change subject: inteltool: Add Intel 200 and Z370 series chipset
......................................................................

Patch Set 1: Code-Review+1

[Iru Cai (Code Review)]

Iru Cai has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/35909 )

Change subject: inteltool: Add Intel 200 and Z370 series chipset
......................................................................

Abandoned