Change in coreboot[master]: src/mainboard/intel: Configure PERST GPIO for PCIE WiFi card

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/24909 )

Change subject: src/mainboard/intel: Configure PERST GPIO for PCIE WiFi card
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/24909/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/24909/1//COMMIT_MSG@7
PS1, Line 7: src/mainboard/intel
mb/intel/glkrvp


https://review.coreboot.org/#/c/24909/1/src/mainboard/intel/glkrvp/variants/...
File src/mainboard/intel/glkrvp/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/24909/1/src/mainboard/intel/glkrvp/variants/...
PS1, Line 198: GPIO_163
Is there an external pull-up on this? Else, you might want to do this configuration early in bootblock.



-- 
To view, visit https://review.coreboot.org/24909
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic594c5a088af79079a8742f5287ed66dcc0ff067
Gerrit-Change-Number: 24909
Gerrit-PatchSet: 1
Gerrit-Owner: Roy Mingi Park <[e-mail]>
Gerrit-Reviewer: Bora Guvendik <[e-mail]>
Gerrit-Reviewer: Hannah Williams <[e-mail]>
Gerrit-Reviewer: Shamile Khan <[e-mail]>
Gerrit-Reviewer: Srinidhi N Kaushik <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Furquan Shaikh <[e-mail]>
Gerrit-Comment-Date: Tue, 27 Feb 2018 23:09:40 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No