Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36005 )
Change subject: soc/intel/broadwell: Use common sb code for SPI lockdown configuration
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36005/4/src/soc/intel/broadwell/inc...
File src/soc/intel/broadwell/include/soc/spi.h:
https://review.coreboot.org/c/coreboot/+/36005/4/src/soc/intel/broadwell/inc...
PS4, Line 43: #define SPIBAR_PREOP 0x94
: #define SPIBAR_OPTYPE 0x96
: #define SPIBAR_OPMENU_LOWER 0x98
: #define SPIBAR_OPMENU_UPPER 0x9c
Drop too?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36005
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a8239f4e9e1f9728074ff5452c95d3138965d82
Gerrit-Change-Number: 36005
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 09 Nov 2019 23:10:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment