Change in ...coreboot[master]: src/lib: Add option to support native display init with vboot 2.0

[Amol N Sukerkar (Code Review)]

Amol N Sukerkar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33845


Change subject: src/lib: Add option to support native display init with vboot 2.0
......................................................................

src/lib: Add option to support native display init with vboot 2.0

This change allows display initialization natively in coreboot with vboot 2.0
authentication mechanism is enabled on a non-chromeos platform.

TEST=Set option CONFIG_VBOOT and clear CONFIG_VBOOT_MAY_SKIP_DISPLAY_INIT
     and the display should initialize in ramstage when platform boots. Set
     CONFIG_VBOOT and set CONFIG_VBOOT_MAY_SKIP_DISPLAY_INIT and the display
     initialization should be skipped in coreboot.

Signed-off-by: Sukerkar, Amol N <[e-mail]>
Change-Id: I51361c267e0317d44a58cc5d740c3beb8924a57b
---
M src/lib/bootmode.c
1 file changed, 7 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/33845/1

diff --git a/src/lib/bootmode.c b/src/lib/bootmode.c
index 737dcf9..bb14cd1 100644
--- a/src/lib/bootmode.c
+++ b/src/lib/bootmode.c
@@ -2,6 +2,7 @@
  * This file is part of the coreboot project.
  *
  * Copyright (C) 2011 The ChromiumOS Authors.  All rights reserved.
+ * Copyright (C) 2019 Intel Corporation.  All rights reserved.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -33,8 +34,12 @@
 
 int display_init_required(void)
 {
-	/* For vboot, always honor VBOOT_WD_FLAG_DISPLAY_INIT. */
-	if (CONFIG(VBOOT)) {
+	/* For vboot, always honor VBOOT_WD_FLAG_DISPLAY_INIT.
+	 * VBOOT_MAY_SKIP_DISPLAY_INIT, when selected, assumes
+	 * CHROMEOS configuration and allows the platform to skip
+	 * display init in normal boot.
+	 */
+	if (CONFIG(VBOOT_MAY_SKIP_DISPLAY_INIT)) {
 		/* Must always select MUST_REQUEST_DISPLAY when using this
 		   function. */
 		if (!CONFIG(VBOOT_MUST_REQUEST_DISPLAY))

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/33845
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51361c267e0317d44a58cc5d740c3beb8924a57b
Gerrit-Change-Number: 33845
Gerrit-PatchSet: 1
Gerrit-Owner: Amol N Sukerkar <[e-mail]>
Gerrit-MessageType: newchange

[Lean Sheng Tan (Code Review)]

Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33845 )

Change subject: src/lib: Add option to support native display init with vboot 2.0
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/33845
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51361c267e0317d44a58cc5d740c3beb8924a57b
Gerrit-Change-Number: 33845
Gerrit-PatchSet: 1
Gerrit-Owner: Amol N Sukerkar <[e-mail]>
Gerrit-Reviewer: Aaron Durbin <[e-mail]>
Gerrit-Reviewer: Amol N Sukerkar <[e-mail]>
Gerrit-Reviewer: Julius Werner <[e-mail]>
Gerrit-Reviewer: Lean Sheng Tan <[e-mail]>
Gerrit-Reviewer: Sachin Agrawal <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Thu, 27 Jun 2019 22:34:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33845 )

Change subject: src/lib: Add option to support native display init with vboot 2.0
......................................................................


Patch Set 1:

(1 comment)

I think you should just squash this patch into the previous one. Adding an option without adding the code that makes it do something isn't very useful.

https://review.coreboot.org/#/c/33845/1/src/lib/bootmode.c 
File src/lib/bootmode.c:

https://review.coreboot.org/#/c/33845/1/src/lib/bootmode.c@40 
PS1, Line 40: 	 * display init in normal boot.
Again, let's not tie this to CHROMEOS. I think you can remove this comment completely, honestly... now that this checks a config option specifically meant to just control this (which has its own documentation), the code here should be clear on its own.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/33845
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51361c267e0317d44a58cc5d740c3beb8924a57b
Gerrit-Change-Number: 33845
Gerrit-PatchSet: 1
Gerrit-Owner: Amol N Sukerkar <[e-mail]>
Gerrit-Reviewer: Aaron Durbin <[e-mail]>
Gerrit-Reviewer: Amol N Sukerkar <[e-mail]>
Gerrit-Reviewer: Julius Werner <[e-mail]>
Gerrit-Reviewer: Lean Sheng Tan <[e-mail]>
Gerrit-Reviewer: Sachin Agrawal <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Fri, 28 Jun 2019 01:28:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Amol N Sukerkar (Code Review)]

Amol N Sukerkar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33845 )

Change subject: src/lib: Add option to support native display init with vboot 2.0
......................................................................


Patch Set 1:
> Patch Set 1:
>
> (1 comment)
>
> I think you should just squash this patch into the previous one. Adding an option without adding the code that makes it do something isn't very useful.

I agree.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/33845
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51361c267e0317d44a58cc5d740c3beb8924a57b
Gerrit-Change-Number: 33845
Gerrit-PatchSet: 1
Gerrit-Owner: Amol N Sukerkar <[e-mail]>
Gerrit-Reviewer: Aaron Durbin <[e-mail]>
Gerrit-Reviewer: Amol N Sukerkar <[e-mail]>
Gerrit-Reviewer: Julius Werner <[e-mail]>
Gerrit-Reviewer: Lean Sheng Tan <[e-mail]>
Gerrit-Reviewer: Sachin Agrawal <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Fri, 28 Jun 2019 22:56:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Amol N Sukerkar (Code Review)]

Amol N Sukerkar has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33845 )

Change subject: src/lib: Add option to support native display init with vboot 2.0
......................................................................


Abandoned

This commit has been squashed into https://review.coreboot.org/c/coreboot/+/33844.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/33845
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51361c267e0317d44a58cc5d740c3beb8924a57b
Gerrit-Change-Number: 33845
Gerrit-PatchSet: 1
Gerrit-Owner: Amol N Sukerkar <[e-mail]>
Gerrit-Reviewer: Aaron Durbin <[e-mail]>
Gerrit-Reviewer: Amol N Sukerkar <[e-mail]>
Gerrit-Reviewer: Julius Werner <[e-mail]>
Gerrit-Reviewer: Lean Sheng Tan <[e-mail]>
Gerrit-Reviewer: Sachin Agrawal <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: abandon