Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30828 )
Change subject: soc/intel/fsp_broadwell_de: Move early_mainboard_romstage_entry()
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/30828/1/src/soc/intel/fsp_broadwell_de/romst...
File src/soc/intel/fsp_broadwell_de/romstage/romstage.c:
https://review.coreboot.org/#/c/30828/1/src/soc/intel/fsp_broadwell_de/romst...
PS1, Line 69: LPC_EN, 0x340f);
Not the scope of the patch, but perhaps these should be read-modify-writes instead of wiping out pre […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30828
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I370263a6197a4c0c805352f07fedddbee1b8e247
Gerrit-Change-Number: 30828
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: York Yang
york.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 14 Jan 2019 09:13:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment