Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36313 )
Change subject: soc/intel/skylake: Pass on reserved_mem_size via cbmem ......................................................................
soc/intel/skylake: Pass on reserved_mem_size via cbmem
This uses common functions to pass on reserved_mem_size from romstage to ramstage over using EBDA, which is a more fragile area in memory.
Change-Id: I6c750eecaf83b9c1fa94c7c22d9e11d7c830b8a2 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/skylake/memmap.c 1 file changed, 12 insertions(+), 31 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/36313/1
diff --git a/src/soc/intel/skylake/memmap.c b/src/soc/intel/skylake/memmap.c index 050cb25..e7de411 100644 --- a/src/soc/intel/skylake/memmap.c +++ b/src/soc/intel/skylake/memmap.c @@ -15,7 +15,6 @@ */
#include <arch/romstage.h> -#include <arch/ebda.h> #include <device/mmio.h> #include <cbmem.h> #include <console/console.h> @@ -29,6 +28,7 @@ #include <soc/pci_devs.h> #include <soc/systemagent.h> #include <stdlib.h> +#include <romstage_handoff.h>
#include "chip.h"
@@ -217,34 +217,11 @@ return dram_base; }
-/* - * SoC implementation - * - * SoC call to summarize all Intel Reserve MMIO size and report to SA - */ size_t soc_reserved_mmio_size(void) { - struct ebda_config cfg; - - retrieve_ebda_object(&cfg); - - /* Get Intel Reserved Memory Range Size */ - return cfg.reserved_mem_size; -} - -/* Fill up memory layout information */ -void fill_soc_memmap_ebda(struct ebda_config *cfg) -{ - size_t chipset_mem_size; - - cfg->tolum_base = calculate_dram_base(&chipset_mem_size); - cfg->reserved_mem_size = chipset_mem_size; -} - -void cbmem_top_init(void) -{ - /* Fill up EBDA area */ - fill_ebda_area(); + size_t reserve_mem_size; + get_romstage_info(&reserve_mem_size, sizeof(reserve_mem_size)); + return reserve_mem_size; }
/* @@ -274,9 +251,13 @@ * | | * +-------------------------+ */ + void *cbmem_top_romstage(void) { - struct ebda_config ebda_cfg; + static uintptr_t dram_base; + size_t reserve_mem_size; + if (dram_base) + return (void *)dram_base;
/* * Check if Tseg has been initialized, we will use this as a flag @@ -287,9 +268,9 @@ if (sa_get_tseg_base() == 0) return NULL;
- retrieve_ebda_object(&ebda_cfg); - - return (void *)(uintptr_t)ebda_cfg.tolum_base; + dram_base = calculate_dram_base(&reserve_mem_size); + save_romstage_info(&reserve_mem_size, sizeof(reserve_mem_size)); + return (void *)dram_base; }
#if CONFIG(PLATFORM_USES_FSP2_0)
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36313
to look at the new patch set (#6).
Change subject: soc/intel/skylake: Pass on reserved_mem_size via cbmem ......................................................................
soc/intel/skylake: Pass on reserved_mem_size via cbmem
This uses common functions to pass on reserved_mem_size from romstage to ramstage over using EBDA, which is a more fragile area in memory.
Change-Id: I6c750eecaf83b9c1fa94c7c22d9e11d7c830b8a2 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/skylake/Kconfig M src/soc/intel/skylake/memmap.c 2 files changed, 20 insertions(+), 31 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/36313/6
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36313
to look at the new patch set (#7).
Change subject: soc/intel/skylake: Pass on reserved_mem_size via cbmem ......................................................................
soc/intel/skylake: Pass on reserved_mem_size via cbmem
This uses common functions to pass on reserved_mem_size from romstage to ramstage over using EBDA, which is a more fragile area in memory.
Change-Id: I6c750eecaf83b9c1fa94c7c22d9e11d7c830b8a2 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/skylake/Kconfig M src/soc/intel/skylake/memmap.c 2 files changed, 20 insertions(+), 31 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/36313/7
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36313
to look at the new patch set (#8).
Change subject: soc/intel/skylake: Don't save tolum_base to ebda ......................................................................
soc/intel/skylake: Don't save tolum_base to ebda
Later stages don't need access to it anymore.
Change-Id: I6c750eecaf83b9c1fa94c7c22d9e11d7c830b8a2 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/skylake/memmap.c 1 file changed, 3 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/36313/8
Hello Patrick Rudolph, Michael Niewöhner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36313
to look at the new patch set (#20).
Change subject: soc/intel/skylake: Don't save tolum_base to ebda ......................................................................
soc/intel/skylake: Don't save tolum_base to ebda
Later stages don't need access to it anymore.
Change-Id: I6c750eecaf83b9c1fa94c7c22d9e11d7c830b8a2 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/skylake/memmap.c 1 file changed, 3 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/36313/20
Hello Patrick Rudolph, Michael Niewöhner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36313
to look at the new patch set (#21).
Change subject: soc/intel/skylake: Don't save tolum_base to ebda ......................................................................
soc/intel/skylake: Don't save tolum_base to ebda
Later stages don't need access to it anymore.
Change-Id: I6c750eecaf83b9c1fa94c7c22d9e11d7c830b8a2 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/skylake/memmap.c 1 file changed, 3 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/36313/21
Hello Patrick Rudolph, Michael Niewöhner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36313
to look at the new patch set (#24).
Change subject: soc/intel/skylake: Don't save tolum_base to ebda ......................................................................
soc/intel/skylake: Don't save tolum_base to ebda
Later stages don't need access to it anymore.
Change-Id: I6c750eecaf83b9c1fa94c7c22d9e11d7c830b8a2 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/skylake/memmap.c 1 file changed, 3 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/36313/24
Hello Patrick Rudolph, Michael Niewöhner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36313
to look at the new patch set (#25).
Change subject: soc/intel/skylake: Don't save tolum_base to ebda ......................................................................
soc/intel/skylake: Don't save tolum_base to ebda
Later stages don't need access to it anymore.
Change-Id: I6c750eecaf83b9c1fa94c7c22d9e11d7c830b8a2 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/skylake/Kconfig M src/soc/intel/skylake/memmap.c 2 files changed, 3 insertions(+), 27 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/36313/25
Hello Patrick Rudolph, Michael Niewöhner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36313
to look at the new patch set (#26).
Change subject: soc/intel/skylake: Don't save tolum_base to ebda ......................................................................
soc/intel/skylake: Don't save tolum_base to ebda
Later stages don't need access to it anymore.
Change-Id: I6c750eecaf83b9c1fa94c7c22d9e11d7c830b8a2 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/skylake/Kconfig M src/soc/intel/skylake/Makefile.inc M src/soc/intel/skylake/memmap.c 3 files changed, 3 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/36313/26
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36313 )
Change subject: soc/intel/skylake: Don't save tolum_base to ebda ......................................................................
Patch Set 26: Code-Review-1
this is superseeded by CB:36614
Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/36313 )
Change subject: soc/intel/skylake: Don't save tolum_base to ebda ......................................................................
Abandoned
-
Arthur Heymans (Code Review) -
Michael Niewöhner (Code Review)