[XS] Change in coreboot[main]: util/lint/lint-000-license-headers: Add license

Attention is currently required from: Martin L Roth, Maximilian Brune. Julius Werner has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84584?usp=email ) Change subject: util/lint/lint-000-license-headers: Add license ...................................................................... Patch Set 1: (1 comment) File util/lint/lint-000-license-headers: https://review.coreboot.org/c/coreboot/+/84584/comment/de26cf27_eb7b035f?usp... : PS1, Line 92: headerlist="$(grep -iL "${LICENSE_ID_STRING}: $1" $headerlist 2>/dev/null)" Should we instead just teach this to parse the OR operator in general? E.g. add second line ``` headerlist="$(grep -eiL "${LICENSE_ID_STRING}: .* OR $1" $headerlist 2>/dev/null)" ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/84584?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I07c508aa6134b063801de36199af9a312a7d6bed Gerrit-Change-Number: 84584 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune@9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Julius Werner <jwerner@chromium.org> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune@9elements.com> Gerrit-Comment-Date: Mon, 30 Sep 2024 23:34:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
participants (1)
-
Julius Werner (Code Review)