Attention is currently required from: Maximilian Brune, Angel Pons, Arthur Heymans, Lean Sheng Tan, David Milosevic.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68137 )
Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI ......................................................................
Patch Set 15: Verified-1
(5 comments)
File src/mainboard/prodrive/atlas/emi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165007): https://review.coreboot.org/c/coreboot/+/68137/comment/33e5c1b7_cb8ee777 PS15, Line 51: switch (access) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165007): https://review.coreboot.org/c/coreboot/+/68137/comment/44c98585_687659c5 PS15, Line 89: switch (access) { switch and case should be at the same indent
File src/mainboard/prodrive/atlas/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165007): https://review.coreboot.org/c/coreboot/+/68137/comment/3ba767e9_80106fe7 PS15, Line 40: static const char* get_smbios_part_number(void) "foo* bar" should be "foo *bar"
File src/mainboard/prodrive/atlas/smbios.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165007): https://review.coreboot.org/c/coreboot/+/68137/comment/82e9be6c_0d351830 PS15, Line 8: const char* smbios_mainboard_serial_number(void) "foo* bar" should be "foo *bar"
File src/mainboard/prodrive/atlas/vpd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165007): https://review.coreboot.org/c/coreboot/+/68137/comment/90be56b0_9a031697 PS15, Line 34: switch (vpd) { switch and case should be at the same indent