Change in coreboot[master]: util/chromeos: Don't execute downloaded, unchecked programs

[Nico Huber (Code Review)]

Hello Matt DeVillier, Patrick Georgi,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/36133

to review the following change.

Change subject: util/chromeos: Don't execute downloaded, unchecked programs
......................................................................

util/chromeos: Don't execute downloaded, unchecked programs

In case of ZIP archives, it's rather easy to avoid. Don't know if
Google always uses ZIP, though.

Change-Id: I95d3760b1690e8e63198609b5b7664bea8882e19
Signed-off-by: Nico Huber 
---
M util/chromeos/crosfirmware.sh
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/36133/1

diff --git a/util/chromeos/crosfirmware.sh b/util/chromeos/crosfirmware.sh
index 9d2ca84..9d3b78c 100755
--- a/util/chromeos/crosfirmware.sh
+++ b/util/chromeos/crosfirmware.sh
@@ -95,7 +95,7 @@
    _unpacked=$( mktemp -d )

echo "Extracting coreboot image"
-	sh $_shellball --sb_extract $_unpacked > /dev/null
+	unzip -o $_shellball -d $_unpacked > /dev/null

_version=$( cat $_unpacked/VERSION | grep BIOS\ version: | \
    		cut -f2 -d: | tr -d \  )

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36133 )

Change subject: util/chromeos: Don't execute downloaded, unchecked programs
......................................................................

Patch Set 1: Code-Review+2

tested on a range of boards old/new

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36133 )

Change subject: util/chromeos: Don't execute downloaded, unchecked programs
......................................................................

Patch Set 1:

Needs more work, there are older images that don't use zip.