Attention is currently required from: Subrata Banik, Kapil Porwal, Ivy Jian, Eric Lai, Utkarsh H Patel.
Sukumar Ghorai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70196 )
Change subject: mb/google/rex: Cnfigure `SLP_S0_GATE_R` aka GPP_H14 PIN low
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
I think we should wait Intel verify this, weird. […]
PAD_CFG_GPO(GPP_H14, 0, PLTRST), -> this does not solve the problem.
We have tested with comment the line //PAD_CFG_GPO(GPP_H14, 0, PLTRST),
a) It must need to be high
b) And need the DSDT method to enable/disable SLP_S0_GATE_R at runtime; As in brya https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70196
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6b5e066f228ea5dc79ae14dd803fc283fd248ce
Gerrit-Change-Number: 70196
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Utkarsh H Patel
utkarsh.h.patel@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Utkarsh H Patel
utkarsh.h.patel@intel.com
Gerrit-Comment-Date: Thu, 01 Dec 2022 16:21:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment