Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Żygowski, Tim Crawford.
Michał Kopeć has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/82673?usp=email )
Change subject: mb/novacustom: add V5x0TU board (Meteor Lake)
......................................................................
Patch Set 18:
(1 comment)
File src/mainboard/novacustom/mtl-h/ramstage.c:
https://review.coreboot.org/c/coreboot/+/82673/comment/a16e5025_ef962bab?usp... :
PS12, Line 43: params->CnviRfResetPinMux = 0x194CE404; // GPP_F04
Can those magic numbers be expressed as some macros from e.g. `gpio_defs. […]
See https://review.coreboot.org/c/coreboot/+/38452/13
Following that discussion, I removed pinmux configuration altogether. I've tested that CNVi Wi-Fi is still working in Fedora 41, including s0ix and toggling on/off
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82673?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I82c73ddb1e76a9baf9b97e13124aa249ae1c2771
Gerrit-Change-Number: 82673
Gerrit-PatchSet: 18
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Thu, 21 Nov 2024 17:04:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com