Attention is currently required from: Julius Werner, Jacob Garber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50480 )
Change subject: drivers/spi: Stop using a variable-length array ......................................................................
Patch Set 1:
(2 comments)
File src/drivers/spi/adesto.c:
https://review.coreboot.org/c/coreboot/+/50480/comment/dc18dd72_3fa310b7 PS1, Line 94: DEFAULT_PAGE_SIZE_SHIFT
Hiding this behind a macro here doesn't feel right to me, even if it's currently the same everywhere […]
Good point
File src/drivers/spi/spi_flash.c:
https://review.coreboot.org/c/coreboot/+/50480/comment/441a53a2_4d24fd6b PS1, Line 95: u8 buff[4 + (1 << DEFAULT_PAGE_SIZE_SHIFT)];
Rather than explicitly tying this to any page size, why not just define a constant like MAX_FLASH_CM […]
Hmmm... The problem is that we need to concatenate two buffers. There must be a better way to avoid this.
-
Angel Pons (Code Review)