Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44218 )
Change subject: cpu/intel/socket_LGA775: Drop commented-out entries ......................................................................
cpu/intel/socket_LGA775: Drop commented-out entries
These CPU models do not exist, and have always been commented-out.
Change-Id: I8fc53fea4225217bc5bb70d839c280ebb64fd3a6 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/intel/socket_LGA775/Kconfig M src/cpu/intel/socket_LGA775/Makefile.inc 2 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/44218/1
diff --git a/src/cpu/intel/socket_LGA775/Kconfig b/src/cpu/intel/socket_LGA775/Kconfig index 8db932c..784cd89 100644 --- a/src/cpu/intel/socket_LGA775/Kconfig +++ b/src/cpu/intel/socket_LGA775/Kconfig @@ -8,8 +8,6 @@ select CPU_INTEL_MODEL_6FX select CPU_INTEL_MODEL_F3X select CPU_INTEL_MODEL_F4X -# select CPU_INTEL_MODEL_F6X -# select CPU_INTEL_MODEL_1066X select CPU_INTEL_MODEL_1067X select MMX select SSE diff --git a/src/cpu/intel/socket_LGA775/Makefile.inc b/src/cpu/intel/socket_LGA775/Makefile.inc index 35a5ad2..29c5761 100644 --- a/src/cpu/intel/socket_LGA775/Makefile.inc +++ b/src/cpu/intel/socket_LGA775/Makefile.inc @@ -9,8 +9,6 @@ subdirs-y += ../model_6fx subdirs-y += ../model_f3x subdirs-y += ../model_f4x -#subdirs-y += ../model_f6x -#subdirs-y += ../model_1066x subdirs-y += ../model_1067x
subdirs-y += ../hyperthreading
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44218 )
Change subject: cpu/intel/socket_LGA775: Drop commented-out entries ......................................................................
Patch Set 1:
I'd keep them.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44218 )
Change subject: cpu/intel/socket_LGA775: Drop commented-out entries ......................................................................
Patch Set 1:
Patch Set 1:
I'd keep them.
Why? `git blame` shows they've been commented out since this file was added to coreboot. Doing a grep for CPU_INTEL_MODEL_F6X or CPU_INTEL_MODEL_1066X shows nothing in coreboot except here
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44218 )
Change subject: cpu/intel/socket_LGA775: Drop commented-out entries ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
I'd keep them.
Why? `git blame` shows they've been commented out since this file was added to coreboot. Doing a grep for CPU_INTEL_MODEL_F6X or CPU_INTEL_MODEL_1066X shows nothing in coreboot except here
I guess because of CB:25565 (which would have to uncomment the entries anyway)
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44218 )
Change subject: cpu/intel/socket_LGA775: Drop commented-out entries ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
I'd keep them.
Why? `git blame` shows they've been commented out since this file was added to coreboot. Doing a grep for CPU_INTEL_MODEL_F6X or CPU_INTEL_MODEL_1066X shows nothing in coreboot except here
I guess because of CB:25565 (which would have to uncomment the entries anyway)
Ah, I see. Elyes, if you resurrect CB:25565, would you be OK with just adding those Kconfig options back in with that patch?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44218 )
Change subject: cpu/intel/socket_LGA775: Drop commented-out entries ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
I'd keep them.
Why? `git blame` shows they've been commented out since this file was added to coreboot. Doing a grep for CPU_INTEL_MODEL_F6X or CPU_INTEL_MODEL_1066X shows nothing in coreboot except here
I guess because of CB:25565 (which would have to uncomment the entries anyway)
Ah, I see. Elyes, if you resurrect CB:25565, would you be OK with just adding those Kconfig options back in with that patch?
This is not a big deal. I'm ok. but I don't understand why you want remove it? They are inhere since the file was added.
I'd give "-1" just to see other reviews.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44218 )
Change subject: cpu/intel/socket_LGA775: Drop commented-out entries ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44218/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44218/1//COMMIT_MSG@9 PS1, Line 9: These CPU models do not exist this is absolutely wrong.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Tim Wawrzynczak, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44218
to look at the new patch set (#2).
Change subject: cpu/intel/socket_LGA775: Drop commented-out entries ......................................................................
cpu/intel/socket_LGA775: Drop commented-out entries
The code for these CPU models isn't present in coreboot. These lines have been commented-out since they where added, so drop them.
Change-Id: I8fc53fea4225217bc5bb70d839c280ebb64fd3a6 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/intel/socket_LGA775/Kconfig M src/cpu/intel/socket_LGA775/Makefile.inc 2 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/44218/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44218 )
Change subject: cpu/intel/socket_LGA775: Drop commented-out entries ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44218/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44218/1//COMMIT_MSG@9 PS1, Line 9: These CPU models do not exist
this is absolutely wrong.
Not "absolutely wrong" but too vague; I meant to say that the code for them does not exist. Updated.
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44218 )
Change subject: cpu/intel/socket_LGA775: Drop commented-out entries ......................................................................
Abandoned
Sorry, I ran out of patience and energy to care about these changes any longer.
Felix Held has restored this change. ( https://review.coreboot.org/c/coreboot/+/44218 )
Change subject: cpu/intel/socket_LGA775: Drop commented-out entries ......................................................................
Restored
Attention is currently required from: Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44218 )
Change subject: cpu/intel/socket_LGA775: Drop commented-out entries ......................................................................
Patch Set 4: Code-Review+2
Attention is currently required from: Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44218 )
Change subject: cpu/intel/socket_LGA775: Drop commented-out entries ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4: I'd appreciate if anyone else could also +2 this. My +2 is only for Felix's rebase, not my own patch.
Attention is currently required from: Angel Pons, Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44218 )
Change subject: cpu/intel/socket_LGA775: Drop commented-out entries ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Patchset:
PS4:
I'd appreciate if anyone else could also +2 this. […]
Done
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44218 )
Change subject: cpu/intel/socket_LGA775: Drop commented-out entries ......................................................................
cpu/intel/socket_LGA775: Drop commented-out entries
The code for these CPU models isn't present in coreboot. These lines have been commented-out since they where added, so drop them.
Change-Id: I8fc53fea4225217bc5bb70d839c280ebb64fd3a6 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44218 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/cpu/intel/socket_LGA775/Kconfig M src/cpu/intel/socket_LGA775/Makefile.inc 2 files changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/cpu/intel/socket_LGA775/Kconfig b/src/cpu/intel/socket_LGA775/Kconfig index 0848d26..7d0bce7 100644 --- a/src/cpu/intel/socket_LGA775/Kconfig +++ b/src/cpu/intel/socket_LGA775/Kconfig @@ -8,8 +8,6 @@ select CPU_INTEL_MODEL_6FX select CPU_INTEL_MODEL_F3X select CPU_INTEL_MODEL_F4X -# select CPU_INTEL_MODEL_F6X -# select CPU_INTEL_MODEL_1066X select CPU_INTEL_MODEL_1067X select MMX select SSE diff --git a/src/cpu/intel/socket_LGA775/Makefile.inc b/src/cpu/intel/socket_LGA775/Makefile.inc index 1f1008e..5200168 100644 --- a/src/cpu/intel/socket_LGA775/Makefile.inc +++ b/src/cpu/intel/socket_LGA775/Makefile.inc @@ -1,8 +1,6 @@ subdirs-y += ../model_6fx subdirs-y += ../model_f3x subdirs-y += ../model_f4x -#subdirs-y += ../model_f6x -#subdirs-y += ../model_1066x subdirs-y += ../model_1067x subdirs-y += ../../x86/lapic subdirs-y += ../microcode
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
HAOUAS Elyes (Code Review)
-
Marshall Dawson (Code Review)
-
Tim Wawrzynczak (Code Review)