Attention is currently required from: Lance Zhao, Marc Jones, Martin Roth, Marshall Dawson, Jonathan Zhang, Paul Menzel, Rocky Phagura, Subrata Banik, Angel Pons, Patrick Rudolph. Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49286 )
Change subject: src/acpi: Add APEI EINJ support ......................................................................
Patch Set 2:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49286/comment/e87f43de_a85ae0c7 PS1, Line 11: acpi_create_einj with an address where action table resides. The action table
It would be more clear to explain that soc code should prepare the action table, and call acpi_creat […]
Done
https://review.coreboot.org/c/coreboot/+/49286/comment/0c97d34f_1f757a82 PS1, Line 13: E820 table.
The action table must be shared memory between FW and OS. […]
Done
File src/acpi/Kconfig:
https://review.coreboot.org/c/coreboot/+/49286/comment/ca11b8b9_2999d600 PS1, Line 31: config ACPI_EINJ
Extra line needed above
Done
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/49286/comment/4b2bfc30_3e87b2de PS1, Line 790: for (i = 0; i < TRIGGER_ACTION_TABLES; i++) {
Not all socs would define all the entries in action table. […]
Done
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/49286/comment/0c1b18f7_9dcfd6cd PS1, Line 76: VFCT, NHLT, SPMI, CRAT, EINJ
EINJ is not a proprietary table, we should move it up and follow alphabetic order.
Done
https://review.coreboot.org/c/coreboot/+/49286/comment/8869fdd2_8920063c PS1, Line 930: #define NO_OP 0x04
please align the values to make it easier to read.
Done
https://review.coreboot.org/c/coreboot/+/49286/comment/ced60eeb_5fb47891 PS1, Line 961: acpi_einj_action_table_t trigger_action[4];
Here 4 is hardcoded. […]
Modified code to allow the caller to pass in the number of actions.
-
Rocky Phagura (Code Review)