[XS] Change in coreboot[main]: arch/x86/memcpy: Change unrecognized instruction movsd to movsq - coreboot-gerrit

30 Oct 2023


      Attention is currently required from: Arthur Heymans, Jérémy Compostella, Martin L Roth.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78819?usp=email )
Change subject: arch/x86/memcpy: Change unrecognized instruction movsd to movsq
......................................................................
Patch Set 1:
(1 comment)
File src/arch/x86/memcpy.c:
https://review.coreboot.org/c/coreboot/+/78819/comment/8819f658_87b97f4e :
PS1, Line 19: 		"rep ; movsq\n\t"
i don't see movsd in the reference i looked at, but movsq seems to be wrong to me, since that will probably end up copying twice the data we want it to
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/78819?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib3f55f50da74a9c24d2fdd0fa45bd0019b2fdc0a
Gerrit-Change-Number: 78819
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 30 Oct 2023 21:24:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment