build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28208 )
Change subject: util/cbfstool: Fix typos ......................................................................
Patch Set 3:
(34 comments)
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c File util/cbfstool/lz4/lib/xxhash.c:
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@68 PS3, Line 68: * By default, xxHash library provides endian-independent Hash values, based on little-endian convention. line over 80 characters
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@222 PS3, Line 222: typedef enum { XXH_bigEndian=0, XXH_littleEndian=1 } XXH_endianness; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@222 PS3, Line 222: typedef enum { XXH_bigEndian=0, XXH_littleEndian=1 } XXH_endianness; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@236 PS3, Line 236: FORCE_INLINE U32 XXH_readLE32_align(const void* ptr, XXH_endianness endian, XXH_alignment align) line over 80 characters
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@236 PS3, Line 236: FORCE_INLINE U32 XXH_readLE32_align(const void* ptr, XXH_endianness endian, XXH_alignment align) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@244 PS3, Line 244: FORCE_INLINE U32 XXH_readLE32(const void* ptr, XXH_endianness endian) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@249 PS3, Line 249: FORCE_INLINE U64 XXH_readLE64_align(const void* ptr, XXH_endianness endian, XXH_alignment align) line over 80 characters
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@249 PS3, Line 249: FORCE_INLINE U64 XXH_readLE64_align(const void* ptr, XXH_endianness endian, XXH_alignment align) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@257 PS3, Line 257: FORCE_INLINE U64 XXH_readLE64(const void* ptr, XXH_endianness endian) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@288 PS3, Line 288: FORCE_INLINE U32 XXH32_endian_align(const void* input, size_t len, U32 seed, XXH_endianness endian, XXH_alignment align) line over 80 characters
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@288 PS3, Line 288: FORCE_INLINE U32 XXH32_endian_align(const void* input, size_t len, U32 seed, XXH_endianness endian, XXH_alignment align) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@374 PS3, Line 374: XXH_endianness endian_detected = (XXH_endianness)XXH_CPU_LITTLE_ENDIAN; please, no spaces at the start of a line
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@393 PS3, Line 393: FORCE_INLINE U64 XXH64_endian_align(const void* input, size_t len, U64 seed, XXH_endianness endian, XXH_alignment align) line over 80 characters
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@393 PS3, Line 393: FORCE_INLINE U64 XXH64_endian_align(const void* input, size_t len, U64 seed, XXH_endianness endian, XXH_alignment align) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@514 PS3, Line 514: XXH_endianness endian_detected = (XXH_endianness)XXH_CPU_LITTLE_ENDIAN; please, no spaces at the start of a line
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@615 PS3, Line 615: FORCE_INLINE XXH_errorcode XXH32_update_endian (XXH32_state_t* state_in, const void* input, size_t len, XXH_endianness endian) line over 80 characters
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@615 PS3, Line 615: FORCE_INLINE XXH_errorcode XXH32_update_endian (XXH32_state_t* state_in, const void* input, size_t len, XXH_endianness endian) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@615 PS3, Line 615: FORCE_INLINE XXH_errorcode XXH32_update_endian (XXH32_state_t* state_in, const void* input, size_t len, XXH_endianness endian) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@615 PS3, Line 615: FORCE_INLINE XXH_errorcode XXH32_update_endian (XXH32_state_t* state_in, const void* input, size_t len, XXH_endianness endian) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@706 PS3, Line 706: XXH_endianness endian_detected = (XXH_endianness)XXH_CPU_LITTLE_ENDIAN; please, no spaces at the start of a line
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@716 PS3, Line 716: FORCE_INLINE U32 XXH32_digest_endian (const XXH32_state_t* state_in, XXH_endianness endian) line over 80 characters
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@716 PS3, Line 716: FORCE_INLINE U32 XXH32_digest_endian (const XXH32_state_t* state_in, XXH_endianness endian) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@716 PS3, Line 716: FORCE_INLINE U32 XXH32_digest_endian (const XXH32_state_t* state_in, XXH_endianness endian) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@760 PS3, Line 760: XXH_endianness endian_detected = (XXH_endianness)XXH_CPU_LITTLE_ENDIAN; please, no spaces at the start of a line
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@769 PS3, Line 769: FORCE_INLINE XXH_errorcode XXH64_update_endian (XXH64_state_t* state_in, const void* input, size_t len, XXH_endianness endian) line over 80 characters
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@769 PS3, Line 769: FORCE_INLINE XXH_errorcode XXH64_update_endian (XXH64_state_t* state_in, const void* input, size_t len, XXH_endianness endian) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@769 PS3, Line 769: FORCE_INLINE XXH_errorcode XXH64_update_endian (XXH64_state_t* state_in, const void* input, size_t len, XXH_endianness endian) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@769 PS3, Line 769: FORCE_INLINE XXH_errorcode XXH64_update_endian (XXH64_state_t* state_in, const void* input, size_t len, XXH_endianness endian) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@860 PS3, Line 860: XXH_endianness endian_detected = (XXH_endianness)XXH_CPU_LITTLE_ENDIAN; please, no spaces at the start of a line
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@870 PS3, Line 870: FORCE_INLINE U64 XXH64_digest_endian (const XXH64_state_t* state_in, XXH_endianness endian) line over 80 characters
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@870 PS3, Line 870: FORCE_INLINE U64 XXH64_digest_endian (const XXH64_state_t* state_in, XXH_endianness endian) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@870 PS3, Line 870: FORCE_INLINE U64 XXH64_digest_endian (const XXH64_state_t* state_in, XXH_endianness endian) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lz4/lib/xxhash.c@954 PS3, Line 954: XXH_endianness endian_detected = (XXH_endianness)XXH_CPU_LITTLE_ENDIAN; please, no spaces at the start of a line
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lzma/C/LzmaEnc.h File util/cbfstool/lzma/C/LzmaEnc.h:
https://review.coreboot.org/#/c/28208/3/util/cbfstool/lzma/C/LzmaEnc.h@40 PS3, Line 40: SZ_ERROR_PARAM - Incorrect parameter in props please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)