[S] Change in coreboot[master]: device/pci_rom: Set VBIOS checksum when filling VFCT table

[Martin L Roth (Code Review)]

Attention is currently required from: CoolStar, Matt DeVillier, Paul Menzel.

Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77628?usp=email )

Change subject: device/pci_rom: Set VBIOS checksum when filling VFCT table
......................................................................

Patch Set 1:

(1 comment)

File src/device/pci_rom.c:

https://review.coreboot.org/c/coreboot/+/77628/comment/1d361c42_b08a7e7b :
PS1, Line 254: 	/* Calculate checksum for VBIOS data. */
> acpi_create_vfct(), which calls pci_rom_acpi_fill_vfct(), is only called on VGA oproms with a VID =  […]

Okay, I didn't realize that. If this is only for AtomBIOS ROMs, it's probably fine, but we might want to add a comment noting that it could be a problem, or maybe change the name of the function to ati_rom_acpi_fill_vfct() just so it's obvious it shouldn't ever be used for something different. I'm fine with whatever you think seems reasonable.