Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36360 )
Change subject: soc/intel/cannonlake: Don't save tolum_base to ebda ......................................................................
soc/intel/cannonlake: Don't save tolum_base to ebda
Later stages don't need access to it anymore.
Change-Id: Ic3b759f28f4969d4da2164ba61562f5cf53c5693 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/cannonlake/memmap.c 1 file changed, 3 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/36360/1
diff --git a/src/soc/intel/cannonlake/memmap.c b/src/soc/intel/cannonlake/memmap.c index 2a25940..dacc3ae 100644 --- a/src/soc/intel/cannonlake/memmap.c +++ b/src/soc/intel/cannonlake/memmap.c @@ -15,7 +15,6 @@ */
#include <arch/romstage.h> -#include <arch/ebda.h> #include <cbmem.h> #include <console/console.h> #include <cpu/x86/mtrr.h> @@ -23,7 +22,6 @@ #include <device/device.h> #include <device/pci.h> #include <fsp/util.h> -#include <intelblocks/ebda.h> #include <intelblocks/systemagent.h> #include <soc/pci_devs.h> #include <soc/systemagent.h> @@ -187,7 +185,7 @@ * the base registers from each other to determine sizes of the regions. In * other words, the memory map is in a fixed order no matter what. */ -static uintptr_t calculate_dram_base(size_t *reserved_mem_size) +static uintptr_t calculate_dram_base(void) { uintptr_t dram_base; const struct device *dev; @@ -204,28 +202,11 @@ dram_base -= calculate_traditional_mem_size(dram_base, dev);
/* Get Intel Reserved Memory Range Size */ - *reserved_mem_size = calculate_reserved_mem_size(dram_base, dev); - - dram_base -= *reserved_mem_size; + dram_base = calculate_reserved_mem_size(dram_base, dev);
return dram_base; }
-/* Fill up memory layout information */ -void fill_soc_memmap_ebda(struct ebda_config *cfg) -{ - size_t chipset_mem_size; - - cfg->tolum_base = calculate_dram_base(&chipset_mem_size); - cfg->reserved_mem_size = chipset_mem_size; -} - -void cbmem_top_init(void) -{ - /* Fill up EBDA area */ - fill_ebda_area(); -} - /* * +-------------------------+ Top of RAM (aligned) * | System Management Mode | @@ -255,8 +236,6 @@ */ void *cbmem_top_romstage(void) { - struct ebda_config ebda_cfg; - /* * Check if Tseg has been initialized, we will use this as a flag * to check if the MRC is done, and only then continue to read the @@ -266,9 +245,7 @@ if (sa_get_tseg_base() == 0) return NULL;
- retrieve_ebda_object(&ebda_cfg); - - return (void *)(uintptr_t)ebda_cfg.tolum_base; + return (void *)calculate_dram_base(); }
void fill_postcar_frame(struct postcar_frame *pcf)
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36360
to look at the new patch set (#17).
Change subject: soc/intel/cannonlake: Don't save tolum_base to ebda ......................................................................
soc/intel/cannonlake: Don't save tolum_base to ebda
Later stages don't need access to it anymore.
Change-Id: Ic3b759f28f4969d4da2164ba61562f5cf53c5693 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/cannonlake/memmap.c 1 file changed, 3 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/36360/17
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36360
to look at the new patch set (#18).
Change subject: soc/intel/cannonlake: Don't save tolum_base to ebda ......................................................................
soc/intel/cannonlake: Don't save tolum_base to ebda
Later stages don't need access to it anymore.
Change-Id: Ic3b759f28f4969d4da2164ba61562f5cf53c5693 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/cannonlake/Kconfig M src/soc/intel/cannonlake/memmap.c 2 files changed, 3 insertions(+), 27 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/36360/18
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36360
to look at the new patch set (#19).
Change subject: soc/intel/cannonlake: Don't save tolum_base to ebda ......................................................................
soc/intel/cannonlake: Don't save tolum_base to ebda
Later stages don't need access to it anymore.
Change-Id: Ic3b759f28f4969d4da2164ba61562f5cf53c5693 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/cannonlake/Kconfig M src/soc/intel/cannonlake/Makefile.inc M src/soc/intel/cannonlake/memmap.c 3 files changed, 3 insertions(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/36360/19
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36360 )
Change subject: soc/intel/cannonlake: Don't save tolum_base to ebda ......................................................................
Patch Set 19:
memmap is common now
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36360 )
Change subject: soc/intel/cannonlake: Don't save tolum_base to ebda ......................................................................
Patch Set 19: Code-Review-1
this is superseeded by CB:36614
Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/36360 )
Change subject: soc/intel/cannonlake: Don't save tolum_base to ebda ......................................................................
Abandoned
-
Arthur Heymans (Code Review) -
Michael Niewöhner (Code Review)