Change in ...coreboot[master]: mb/google/hatch: Fixes to initial hatch mainboard checkin
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30296 )
Change subject: mb/google/hatch: Fixes to initial hatch mainboard checkin ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/#/c/30296/6/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/#/c/30296/6/src/mainboard/google/hatch/Kconfig@a... PS6, Line 5: : :
Need it now for Trackpad and TPM
Done
https://review.coreboot.org/#/c/30296/7/src/mainboard/google/hatch/chromeos.... File src/mainboard/google/hatch/chromeos.fmd:
https://review.coreboot.org/#/c/30296/7/src/mainboard/google/hatch/chromeos.... PS7, Line 32:
please adjust the subsequent sections' base and size so as to not leave any unmapped areas
Done
https://review.coreboot.org/#/c/30296/7/src/mainboard/google/hatch/chromeos.... PS7, Line 4: SI_ME
u can safely say to avoid having unused section there […]
I have set SI_ALL=3MB and aligned the base and sizes.
-
V Sowmya (Code Review)