Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32350 )
Change subject: src/arch/x86:Add support for low power idle table
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32350/4/src/arch/x86/acpi.c
File src/arch/x86/acpi.c:
https://review.coreboot.org/c/coreboot/+/32350/4/src/arch/x86/acpi.c@1253
PS4, Line 1253: __weak void soc_residency_counter(struct acpi_lpit_native *lpit_native)
To summarize i will only keep the function like acpi_create_lpit_generator here which would call a […]
Well, as I said, I'm not really sure anymore if we need soc-specifics at all (besides macros for msrs/adresses), as I proposed earlier. What do you think? Are there socs that really differ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32350
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie76ab0d50f09c98762bc674c2758520d53789137
Gerrit-Change-Number: 32350
Gerrit-PatchSet: 4
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Mon, 02 Nov 2020 10:13:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shaunak Saha
shaunak.saha@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment