Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42278 )
Change subject: postcode: added and reorganized postcodes
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42278/4/src/include/console/post_co...
File src/include/console/post_codes.h:
https://review.coreboot.org/c/coreboot/+/42278/4/src/include/console/post_co...
PS4, Line 75: POST_BOOTBLOCK_PRE_C_EXIT
why _EXIT?
bootblock_pre_c_entry?
https://review.coreboot.org/c/coreboot/+/42278/4/src/include/console/post_co...
PS4, Line 141: POST_ENTRY_BOOTBLOCK_STACK
at this point already 48 postcodes are used.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42278
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I02d09d0b2bad3f9a93fff54d11a5ba5e53fadbcc
Gerrit-Change-Number: 42278
Gerrit-PatchSet: 4
Gerrit-Owner: Sindhoor Tilak
sindhoor@sin9yt.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jun 2020 08:15:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment