Attention is currently required from: Martin Roth, Henry Sun, Evan Green.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49469 )
Change subject: mb/google/dedede/var/drawcia: Add support to handle pen detection
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/google/dedede/variants/drawcia/gpio.c:
https://review.coreboot.org/c/coreboot/+/49469/comment/1918cacc_4057c800
PS6, Line 17: if (fw_config_probe(FW_CONFIG(TABLETMODE, TABLETMODE_ENABLED))){
space required before the open brace '{'
https://review.coreboot.org/c/coreboot/+/49469/comment/66a02546_f79c1de8
PS6, Line 17: if (fw_config_probe(FW_CONFIG(TABLETMODE, TABLETMODE_ENABLED))){
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49469
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I503873afb48384168dcd8a822c7246655898356e
Gerrit-Change-Number: 49469
Gerrit-PatchSet: 6
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Evan Green
evgreen@chromium.org
Gerrit-Comment-Date: Wed, 20 Jan 2021 02:54:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment