[M] Change in coreboot[master]: soc/amd/common/psp_verstage: Map/unmap boot device on need basis - coreboot-gerrit

10 May 2023


      Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Martin Roth, Fred Reitberger, Elyes Haouas, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74606 )
Change subject: soc/amd/common/psp_verstage: Map/unmap boot device on need basis
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/common/psp_verstage/boot_dev.c:
https://review.coreboot.org/c/coreboot/+/74606/comment/a280053a_889c64f8 
PS1, Line 42: mdev->base
...
My only concern is that we have some common code somewhere that we missed. […]
I think if it is not mapped, then we should get a page fault based on my understanding.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74606
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd44ea7b2a366e9269debcab4186d1fc71651db2
Gerrit-Change-Number: 74606
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anand Vaikar a.vaikar2021@gmail.com
Gerrit-CC: Elyes Haouas ehaouas@noos.fr
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 10 May 2023 19:37:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Gerrit-MessageType: comment