Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47635 )
Change subject: nvramcui: Make local render_form() function static ......................................................................
nvramcui: Make local render_form() function static
Allows us to build with `-Wmissing-prototypes`.
Change-Id: I722b41e515ee472697028a912b9136ce59611051 Signed-off-by: Nico Huber nico.h@gmx.de --- M payloads/nvramcui/nvramcui.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/47635/1
diff --git a/payloads/nvramcui/nvramcui.c b/payloads/nvramcui/nvramcui.c index ee3de1c..db3e522 100644 --- a/payloads/nvramcui/nvramcui.c +++ b/payloads/nvramcui/nvramcui.c @@ -37,7 +37,7 @@ return y; }
-void render_form(FORM *form) +static void render_form(FORM *form) { int y, x, line; WINDOW *w = form_win(form);
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47635 )
Change subject: nvramcui: Make local render_form() function static ......................................................................
Patch Set 2: Code-Review+1
Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47635 )
Change subject: nvramcui: Make local render_form() function static ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47635 )
Change subject: nvramcui: Make local render_form() function static ......................................................................
nvramcui: Make local render_form() function static
Allows us to build with `-Wmissing-prototypes`.
Change-Id: I722b41e515ee472697028a912b9136ce59611051 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/47635 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M payloads/nvramcui/nvramcui.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/payloads/nvramcui/nvramcui.c b/payloads/nvramcui/nvramcui.c index ee3de1c..db3e522 100644 --- a/payloads/nvramcui/nvramcui.c +++ b/payloads/nvramcui/nvramcui.c @@ -37,7 +37,7 @@ return y; }
-void render_form(FORM *form) +static void render_form(FORM *form) { int y, x, line; WINDOW *w = form_win(form);