Attention is currently required from: Jakub Czapiga, Subrata Banik, Tarun Tuli.
Kapil Porwal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76225?usp=email )
Change subject: Revert "mb/google/rex: Avoid boot hang due to missing SOC/IOE SRAM device" ......................................................................
Revert "mb/google/rex: Avoid boot hang due to missing SOC/IOE SRAM device"
This reverts commit dc69b15ed7e7fb89e52d9abec104c54e26bd1456.
Reason: System is unable to boot reliably.
BUG=b:289749310
Signed-off-by: Kapil Porwal kapilporwal@google.com Change-Id: I603b3f3e754c652e6ba46645421d7a16fda2e6da --- M src/mainboard/google/rex/Kconfig M src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb M src/mainboard/google/rex/variants/rex0/overridetree.cb 3 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/76225/1
diff --git a/src/mainboard/google/rex/Kconfig b/src/mainboard/google/rex/Kconfig index f131b70..4bb9a67 100644 --- a/src/mainboard/google/rex/Kconfig +++ b/src/mainboard/google/rex/Kconfig @@ -25,9 +25,11 @@ select MAINBOARD_HAS_TPM2 select PMC_IPC_ACPI_INTERFACE select SOC_INTEL_COMMON_BLOCK_VARIANT_POWER_LIMIT + select SOC_INTEL_CRASHLOG select SOC_INTEL_CSE_LITE_SKU select SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY_V2 select SOC_INTEL_CSE_SEND_EOP_ASYNC + select SOC_INTEL_IOE_DIE_SUPPORT
config BOARD_GOOGLE_BASEBOARD_REX def_bool n @@ -38,8 +40,6 @@ select HAVE_SLP_S0_GATE select MAINBOARD_HAS_CHROMEOS select MEMORY_SOLDERDOWN - select SOC_INTEL_CRASHLOG - select SOC_INTEL_IOE_DIE_SUPPORT select SOC_INTEL_METEORLAKE_U_H select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES select SYSTEM_TYPE_LAPTOP diff --git a/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb b/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb index 76b9dcd..7acc0ae 100644 --- a/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb +++ b/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb @@ -73,7 +73,6 @@ device domain 0 on device ref igpu on end device ref dtt on end - device ref ioe_shared_sram on end device ref xhci on end device ref pmc_shared_sram on end device ref heci1 on end diff --git a/src/mainboard/google/rex/variants/rex0/overridetree.cb b/src/mainboard/google/rex/variants/rex0/overridetree.cb index 4f74ea4..bd38595 100644 --- a/src/mainboard/google/rex/variants/rex0/overridetree.cb +++ b/src/mainboard/google/rex/variants/rex0/overridetree.cb @@ -349,6 +349,7 @@ device generic 0 on end end end + device ref ioe_shared_sram on end device ref xhci on chip drivers/usb/acpi device ref xhci_root_hub on @@ -412,6 +413,7 @@ end end end + device ref pmc_shared_sram on end device ref cnvi_wifi on chip drivers/wifi/generic register "wake" = "GPE0_PME_B0"