Attention is currently required from: Furquan Shaikh, Aamir Bohra, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51258 )
Change subject: mb/google/brya: brya0: Add ACPI support for Type-C ports
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51258/comment/682d1188_7892008b
PS1, Line 8:
BUG=b:?
Done
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/51258/comment/3fa2c3f6_fbc18f67
PS1, Line 214: # SBU & HSL follow CC
Why is this comment specific to port0?
Oh forgot to remove it, it really applies to all of them (indicated by lack of `sbu_orientation` or `hsl_orientation` registers)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51258
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic201ad047fd0d593749d2b993f843f7e188a5c98
Gerrit-Change-Number: 51258
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 04 Mar 2021 18:02:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment