Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/77567?usp=email )
(
8 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soc/intel/meteorlake: Correctly set Usb4CmMode ......................................................................
soc/intel/meteorlake: Correctly set Usb4CmMode
The ACPI is adjusted based on SOFTWARE_CONNECTION_MANAGER, so set the UPD to match this to avoid the connection type being mismatched.
If it's mismatched, the TBT port will timeout.
TEST=Boot starbook/rpl and check TBT 4 dock is correctly identified.
Signed-off-by: Sean Rhodes sean@starlabs.systems Change-Id: I3ab68c01f682723dab39870f0676e59ae3d89add Reviewed-on: https://review.coreboot.org/c/coreboot/+/77567 Reviewed-by: Tim Crawford tcrawford@system76.com Reviewed-by: Ronak Kanabar ronak.kanabar@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michał Kopeć michal.kopec@3mdeb.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/meteorlake/fsp_params.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: Michał Kopeć: Looks good to me, approved Tim Crawford: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Ronak Kanabar: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/soc/intel/meteorlake/fsp_params.c b/src/soc/intel/meteorlake/fsp_params.c index bf1d9d5..702820a 100644 --- a/src/soc/intel/meteorlake/fsp_params.c +++ b/src/soc/intel/meteorlake/fsp_params.c @@ -442,6 +442,8 @@ if (is_dev_enabled(tcss_port_arr[i])) s_cfg->UsbTcPortEn |= BIT(i); } + + s_cfg->Usb4CmMode = CONFIG(SOFTWARE_CONNECTION_MANAGER); }
static void fill_fsps_chipset_lockdown_params(FSP_S_CONFIG *s_cfg,