Attention is currently required from: Arthur Heymans, Benjamin Doron, Felix Held, Patrick Rudolph.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79160?usp=email )
Change subject: Documentation: Improve x86_64 ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Patchset:
PS2: Thanks again for working on this documentation.
File Documentation/arch/x86/x86_64.md:
https://review.coreboot.org/c/coreboot/+/79160/comment/44c751da_9a598ab2 : PS1, Line 24: : The large memory model causes the compiler to emit 64bit addressing : instructions, which are not only slower, but also increase code size.
Page tables can be used to provide security benefits, such as by marking memory as non-executable or […]
Sorry, I was suggesting that the response to the question be added into the document. The way it's currently worded leaves one wondering if there's any benefit and why we'd want it.
https://review.coreboot.org/c/coreboot/+/79160/comment/ea1189b0_890b8a9b : PS1, Line 28: must generate page tables at build time
I'm not sure I understand? If you're asking if long mode architecturally needs page tables in ROM, n […]
The statement is that the toolchain *must* do this. Maybe rephrase it saying that this is coreboot's implementation and not a requirement.
-
Martin L Roth (Code Review)