Attention is currently required from: Elyes Haouas, Martin L Roth.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76844?usp=email )
Change subject: drivers/aspeed/common/ast_drv.h: Use C99 flexible arrays ......................................................................
Patch Set 2:
(1 comment)
File src/drivers/aspeed/common/ast_drv.h:
https://review.coreboot.org/c/coreboot/+/76844/comment/ef8b12ba_025efdc7 : PS2, Line 251: struct drm_format { : u32 cpp[]; /* Colors per pixel */ : }; :
Unfortunately, this gives an error. […]
Can't we just replace ``` u32 cpp[1]; ``` with ``` u32 cpp; ``` ? Looking at the references of the "cpp" property in the coreboot tree it seems like only the first element is always referenced and its not actually used in a flexible array manner.