Change in coreboot[master]: mb/google/brya: Use PAD config macro to add lock support - coreboot-gerrit

5 Jan 2022


      Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Meera Ravindranath, Nick Vaccaro, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60320 )
Change subject: mb/google/brya: Use PAD config macro to add lock support
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7: 
Thanks for review CL Meera, Can you please check my comments on bug as well, where I have asked to remove the ENV_SMM check and make sure coreboot gpio pad config can also program the lock bit. 
can you please try that as well. In that works, I want to skip SBI programming and simple perform MMIO write.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/60320
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I558bab39f935ab31a89541c6498a73af70cbf9ee
Gerrit-Change-Number: 60320
Gerrit-PatchSet: 7
Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Meera Ravindranath meera.ravindranath@intel.com
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Attention: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 05 Jan 2022 08:03:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment