Marc Jones (marc.jones@se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7945
-gerrit
commit 0e87dcaea1b37d7d39384d0ae74e6cce8ad2c03e Author: Shawn Nematbakhsh shawnn@chromium.org Date: Fri May 16 15:40:21 2014 -0700
rambi: Add _PRW for LID0 ACPI Device
The kernel will not track wakeup events for devices unless they have a defined _PRW. There is no EC output of the lid signal coming to a GPIO and instead it pulses PCH_WAKE#.
BUG=chrome-os-partner:27631 TEST=Manual on Rambi. - Run lidclose + lidopen on EC console, verify that wakeup_count increments. - Run lidclose + lidopen in rapid succession, verify that suspend request is aborted. BRANCH=Rambi.
Original-Change-Id: I8d4c58a7bb37d7e474ec094fe96e46e1bfd980de Original-Signed-off-by: Shawn Nematbakhsh shawnn@chromium.org Original-Reviewed-on: https://chromium-review.googlesource.com/200289 Original-Reviewed-by: Duncan Laurie dlaurie@chromium.org (cherry picked from commit 08c6b42f1ed1af7fff6217e6b71469edd7ff4b2e) Signed-off-by: Marc Jones marc.jones@se-eng.com
Change-Id: Iee813ed6f39cd3d5e0a2bdd395c740f82a1cf01a --- src/mainboard/google/rambi/acpi/mainboard.asl | 1 + src/mainboard/google/rambi/onboard.h | 3 +++ 2 files changed, 4 insertions(+)
diff --git a/src/mainboard/google/rambi/acpi/mainboard.asl b/src/mainboard/google/rambi/acpi/mainboard.asl index f0f7a4c..e6a7448 100644 --- a/src/mainboard/google/rambi/acpi/mainboard.asl +++ b/src/mainboard/google/rambi/acpi/mainboard.asl @@ -26,6 +26,7 @@ Scope (_SB) Device (LID0) { Name (_HID, EisaId ("PNP0C0D")) + Name (_PRW, Package() { BOARD_PCH_WAKE_GPIO, 0x5 }) Method (_LID, 0) { Store (_SB.PCI0.LPCB.EC0.LIDS, \LIDS) diff --git a/src/mainboard/google/rambi/onboard.h b/src/mainboard/google/rambi/onboard.h index 18ceca3..8ea2e8a 100644 --- a/src/mainboard/google/rambi/onboard.h +++ b/src/mainboard/google/rambi/onboard.h @@ -22,6 +22,9 @@
#include "irqroute.h"
+/* PCH wake signal from EC. */ +#define BOARD_PCH_WAKE_GPIO ACPI_ENABLE_WAKE_SUS_GPIO(0) + #define BOARD_TRACKPAD_NAME "trackpad" #define BOARD_TRACKPAD_IRQ GPIO_S0_DED_IRQ(TPAD_IRQ_OFFSET) #define BOARD_TRACKPAD_WAKE_GPIO ACPI_ENABLE_WAKE_SUS_GPIO(1)