Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38169 )
Change subject: soc/amd/picasso: Add PCI ID for Dali xHCI ......................................................................
soc/amd/picasso: Add PCI ID for Dali xHCI
soc//picasso is intended to be forward-compatible with the Dali APU, a Family 17h Models 20h-2Fh product. Add the one new device ID it has. See PPR document #55772 (still NDA only) for more information.
Change-Id: I7e9b90bb00ae6f4a121f10b1467d2ca398ac860c Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/include/device/pci_ids.h M src/soc/amd/picasso/usb.c 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/38169/1
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index bd5b3a5..52c6035 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -459,6 +459,7 @@ #define PCI_DEVICD_ID_AMD_PCO_ACP 0x15e2 #define PCI_DEVICE_ID_AMD_PCO_XHCI0 0x15e0 #define PCI_DEVICE_ID_AMD_PCO_XHCI1 0x15e1 +#define PCI_DEVICE_ID_AMD_DALI_XHCI 0x15e5
#define PCI_VENDOR_ID_VLSI 0x1004 #define PCI_DEVICE_ID_VLSI_82C592 0x0005 diff --git a/src/soc/amd/picasso/usb.c b/src/soc/amd/picasso/usb.c index 80e960c..faea3c3 100644 --- a/src/soc/amd/picasso/usb.c +++ b/src/soc/amd/picasso/usb.c @@ -48,6 +48,7 @@ static const unsigned short pci_device_ids[] = { PCI_DEVICE_ID_AMD_PCO_XHCI0, PCI_DEVICE_ID_AMD_PCO_XHCI1, + PCI_DEVICE_ID_AMD_DALI_XHCI, 0 };
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38169 )
Change subject: soc/amd/picasso: Add PCI ID for Dali xHCI ......................................................................
Patch Set 1: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38169 )
Change subject: soc/amd/picasso: Add PCI ID for Dali xHCI ......................................................................
Patch Set 1: Code-Review+1
Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38169 )
Change subject: soc/amd/picasso: Add PCI ID for Dali xHCI ......................................................................
Patch Set 1: Code-Review+1
0x15e5 looks righ5t according to rev 3.06.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38169 )
Change subject: soc/amd/picasso: Add PCI ID for Dali xHCI ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38169 )
Change subject: soc/amd/picasso: Add PCI ID for Dali xHCI ......................................................................
soc/amd/picasso: Add PCI ID for Dali xHCI
soc//picasso is intended to be forward-compatible with the Dali APU, a Family 17h Models 20h-2Fh product. Add the one new device ID it has. See PPR document #55772 (still NDA only) for more information.
Change-Id: I7e9b90bb00ae6f4a121f10b1467d2ca398ac860c Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38169 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Eric Peers epeers@google.com Reviewed-by: Martin Roth martinroth@google.com --- M src/include/device/pci_ids.h M src/soc/amd/picasso/usb.c 2 files changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Eric Peers: Looks good to me, but someone else must approve
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 47b1825..e2dc28e 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -459,6 +459,7 @@ #define PCI_DEVICD_ID_AMD_PCO_ACP 0x15e2 #define PCI_DEVICE_ID_AMD_PCO_XHCI0 0x15e0 #define PCI_DEVICE_ID_AMD_PCO_XHCI1 0x15e1 +#define PCI_DEVICE_ID_AMD_DALI_XHCI 0x15e5
#define PCI_VENDOR_ID_VLSI 0x1004 #define PCI_DEVICE_ID_VLSI_82C592 0x0005 diff --git a/src/soc/amd/picasso/usb.c b/src/soc/amd/picasso/usb.c index 80e960c..faea3c3 100644 --- a/src/soc/amd/picasso/usb.c +++ b/src/soc/amd/picasso/usb.c @@ -48,6 +48,7 @@ static const unsigned short pci_device_ids[] = { PCI_DEVICE_ID_AMD_PCO_XHCI0, PCI_DEVICE_ID_AMD_PCO_XHCI1, + PCI_DEVICE_ID_AMD_DALI_XHCI, 0 };
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38169 )
Change subject: soc/amd/picasso: Add PCI ID for Dali xHCI ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1034 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1033 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1032
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Eric Peers (Code Review)
-
HAOUAS Elyes (Code Review)
-
Marshall Dawson (Code Review)
-
Martin Roth (Code Review)
-
Paul Menzel (Code Review)