[S] Change in coreboot[master]: soc/amd/phoenix: Remove TODO after review

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76165?usp=email )

Change subject: soc/amd/phoenix: Remove TODO after review
......................................................................

soc/amd/phoenix: Remove TODO after review

Signed-off-by: Fred Reitberger 
Change-Id: Ifd2b53ff24776238190eb946db7b12827fcfc804
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76165
Tested-by: build bot (Jenkins) 
Reviewed-by: Matt DeVillier 
---
M src/soc/amd/phoenix/Kconfig
M src/soc/amd/phoenix/include/soc/espi.h
M src/soc/amd/phoenix/include/soc/uart.h
3 files changed, 3 insertions(+), 9 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Matt DeVillier: Looks good to me, approved

diff --git a/src/soc/amd/phoenix/Kconfig b/src/soc/amd/phoenix/Kconfig
index 4ab26ee..a9f124c 100644
--- a/src/soc/amd/phoenix/Kconfig
+++ b/src/soc/amd/phoenix/Kconfig
@@ -37,12 +37,12 @@
    select SOC_AMD_COMMON_BLOCK_ACPI		# TODO: Check if this is still correct
    select SOC_AMD_COMMON_BLOCK_ACPIMMIO		# TODO: Check if this is still correct
    select SOC_AMD_COMMON_BLOCK_ACPI_ALIB		# TODO: Check if this is still correct
-	select SOC_AMD_COMMON_BLOCK_ACPI_CPPC		# TODO: Check if this is still correct
+	select SOC_AMD_COMMON_BLOCK_ACPI_CPPC
    select SOC_AMD_COMMON_BLOCK_ACPI_CPU_POWER_STATE
    select SOC_AMD_COMMON_BLOCK_ACPI_GPIO		# TODO: Check if this is still correct
    select SOC_AMD_COMMON_BLOCK_ACPI_IVRS		# TODO: Check if this is still correct
    select SOC_AMD_COMMON_BLOCK_AOAC
-	select SOC_AMD_COMMON_BLOCK_APOB		# TODO: Check if this is still correct
+	select SOC_AMD_COMMON_BLOCK_APOB
    select SOC_AMD_COMMON_BLOCK_APOB_HASH
    select SOC_AMD_COMMON_BLOCK_BANKED_GPIOS
    select SOC_AMD_COMMON_BLOCK_CPUFREQ_FAM17H_19H
@@ -77,7 +77,7 @@
    select SOC_AMD_COMMON_BLOCK_UART
    select SOC_AMD_COMMON_BLOCK_UCODE
    select SOC_AMD_COMMON_BLOCK_XHCI
-	select SOC_AMD_COMMON_FSP_CCX_CPPC_HOB		# TODO: Check if this is still correct
+	select SOC_AMD_COMMON_FSP_CCX_CPPC_HOB
    select SOC_AMD_COMMON_FSP_DMI_TABLES
    select SOC_AMD_COMMON_FSP_PCI			# TODO: Check if this is still correct
    select SOC_AMD_COMMON_FSP_PRELOAD_FSPS
diff --git a/src/soc/amd/phoenix/include/soc/espi.h b/src/soc/amd/phoenix/include/soc/espi.h
index 057332a..5968da0e 100644
--- a/src/soc/amd/phoenix/include/soc/espi.h
+++ b/src/soc/amd/phoenix/include/soc/espi.h
@@ -1,7 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

-/* TODO: Update for Phoenix */
-
 #ifndef AMD_PHOENIX_ESPI_H
 #define AMD_PHOENIX_ESPI_H

diff --git a/src/soc/amd/phoenix/include/soc/uart.h b/src/soc/amd/phoenix/include/soc/uart.h
index b8d6e17..5b941b2 100644
--- a/src/soc/amd/phoenix/include/soc/uart.h
+++ b/src/soc/amd/phoenix/include/soc/uart.h
@@ -1,12 +1,8 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

-/* TODO: Update for Phoenix */
-
 #ifndef AMD_PHOENIX_UART_H
 #define AMD_PHOENIX_UART_H

-#include <types.h>
-
 void clear_uart_legacy_config(void); /* disable legacy I/O decode for FCH UART */

#endif /* AMD_PHOENIX_UART_H */