Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60780 )
Change subject: mb/google/corsola: Set GPIO to enable SD card bridge IC
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/mainboard/google/corsola/mainboard.c:
https://review.coreboot.org/c/coreboot/+/60780/comment/44f1b146_9d251616
PS2, Line 46: if (CONFIG(BOARD_GOOGLE_KINGLER_COMMON))
: gpio_output(GPIO_EN_PP3300_SDBRDG_X, 1);
: else
: mtk_msdc_configure_sdcard();
I'm confused. for SDCARD_INIT, […]
yes, there is no sd card control using msdc1 from 8186.
I have removed them.
If there is any requirement for future projects, we can add them back.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60780
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I903731ea4906328b2f0f5a7c6c06bd9c964d24ec
Gerrit-Change-Number: 60780
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 05 Jan 2022 03:34:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment