Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72858 )
Change subject: cpu/intel/model_206ax: use CPUID_FROM_FMS macro instead of magic numbers ......................................................................
cpu/intel/model_206ax: use CPUID_FROM_FMS macro instead of magic numbers
TEST=Resulting image of timeless build for x230 doesn't change.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I77984574584c4074e350cee04a69cc5680257e98 --- M src/cpu/intel/model_206ax/model_206ax_init.c 1 file changed, 16 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/72858/1
diff --git a/src/cpu/intel/model_206ax/model_206ax_init.c b/src/cpu/intel/model_206ax/model_206ax_init.c index 04a9d2d..c8293fc 100644 --- a/src/cpu/intel/model_206ax/model_206ax_init.c +++ b/src/cpu/intel/model_206ax/model_206ax_init.c @@ -427,8 +427,10 @@ };
static const struct cpu_device_id cpu_table[] = { - { X86_VENDOR_INTEL, 0x206a0, CPUID_ALL_STEPPINGS_MASK }, /* Intel Sandybridge */ - { X86_VENDOR_INTEL, 0x306a0, CPUID_ALL_STEPPINGS_MASK }, /* Intel IvyBridge */ + /* Intel Sandybridge */ + { X86_VENDOR_INTEL, CPUID_FROM_FMS(0x6, 0x2a, 0), CPUID_ALL_STEPPINGS_MASK }, + /* Intel IvyBridge */ + { X86_VENDOR_INTEL, CPUID_FROM_FMS(0x6, 0x3a, 0), CPUID_ALL_STEPPINGS_MASK }, { 0, 0, 0 }, };