Change in coreboot[master]: mb/google/volteer: Add DB_USB3_NO_C option for DB_USB field
Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46906 ) Change subject: mb/google/volteer: Add DB_USB3_NO_C option for DB_USB field ...................................................................... mb/google/volteer: Add DB_USB3_NO_C option for DB_USB field Define option value 6 for DB_USB where there is a Type-A port but no Type-C port on the daughterboard. BUG=b:151731851 TEST=build volteer boards Change-Id: I489d24316556dedfecd821e502f1461010b1400f Signed-off-by: Duncan Laurie <dlaurie@google.com> --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/46906/1 diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 2a62505..7c73328 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -6,6 +6,7 @@ option USB4_GEN3 3 option USB3_PASSIVE 4 option USB3_NO_A 5 + option USB3_NO_C 6 end field THERMAL 4 7 end field AUDIO 8 10 -- To view, visit https://review.coreboot.org/c/coreboot/+/46906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I489d24316556dedfecd821e502f1461010b1400f Gerrit-Change-Number: 46906 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> Gerrit-MessageType: newchange
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46906 ) Change subject: mb/google/volteer: Add DB_USB3_NO_C option for DB_USB field ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/46906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I489d24316556dedfecd821e502f1461010b1400f Gerrit-Change-Number: 46906 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Fri, 30 Oct 2020 19:15:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46906 ) Change subject: mb/google/volteer: Add DB_USB3_NO_C option for DB_USB field ...................................................................... mb/google/volteer: Add DB_USB3_NO_C option for DB_USB field Define option value 6 for DB_USB where there is a Type-A port but no Type-C port on the daughterboard. BUG=b:151731851 TEST=build volteer boards Change-Id: I489d24316556dedfecd821e502f1461010b1400f Signed-off-by: Duncan Laurie <dlaurie@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/46906 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index bbec04b..20a3843 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -6,6 +6,7 @@ option USB4_GEN3 3 option USB3_PASSIVE 4 option USB3_NO_A 5 + option USB3_NO_C 6 end field THERMAL 4 7 end field AUDIO 8 10 -- To view, visit https://review.coreboot.org/c/coreboot/+/46906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I489d24316556dedfecd821e502f1461010b1400f Gerrit-Change-Number: 46906 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: merged
participants (3)
-
Duncan Laurie (Code Review) -
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)