[XS] Change in coreboot[main]: stddef.h: Introduce nullptr constant

Attention is currently required from: Elyes Haouas, Felix Singer, Jakub Czapiga, Martin L Roth, Maximilian Brune, Nico Huber. Julius Werner has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83459?usp=email ) Change subject: stddef.h: Introduce nullptr constant ...................................................................... Patch Set 26: Code-Review+2 (1 comment) File src/include/stddef.h: https://review.coreboot.org/c/coreboot/+/83459/comment/2cb60a56_06552442?usp... : PS26, Line 25: #define nullptr ((void *)0)
I also don't think people are against using it. […] I don't remember exactly what was said but I agree with Felix here: I think the important part is that we don't want to rewrite existing code and keep using NULL by default in new code. But I'm okay with adding these definitions here and resolving NULL to nullptr when available for whatever tiny type-checking advantage that may bring. Having the name nullptr defined may be useful in rare cases where we're importing code wholesale from somewhere that uses it, although I don't think we should start using it in normal coreboot code.
-- To view, visit https://review.coreboot.org/c/coreboot/+/83459?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I07db866bebfd25f1a60d18a3228ada2957500234 Gerrit-Change-Number: 83459 Gerrit-PatchSet: 26 Gerrit-Owner: Elyes Haouas <ehaouas@noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <czapiga@google.com> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune@9elements.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-Attention: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: Jakub Czapiga <czapiga@google.com> Gerrit-Attention: Maximilian Brune <maximilian.brune@9elements.com> Gerrit-Attention: Elyes Haouas <ehaouas@noos.fr> Gerrit-Comment-Date: Mon, 30 Sep 2024 23:23:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit@felixsinger.de> Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Comment-In-Reply-To: Elyes Haouas <ehaouas@noos.fr>
participants (1)
-
Julius Werner (Code Review)