Attention is currently required from: Ivy Jian, Shelley Chen.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79392?usp=email )
Change subject: mb/google/brox: Generate RAM IDs ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brox/variants/brox/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/79392/comment/676db120_6b019db3 : PS1, Line 4: /tmp/go-build3467193440/b001/exe/part_id_gen
Did you use a local copy of the script? I'd rather keep the path to the common script in the repo s […]
I think Ivy ran `go run util/spd_tools/src/part_id_gen/part_id_gen.go ADL lp5 ...`
That is why the exe was built into tmp path and executed from there.
-
Karthik Ramasubramanian (Code Review)