Stanley Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48878 )
Change subject: mb/google/dedede/var/boten: Configure I2C high and low time ......................................................................
mb/google/dedede/var/boten: Configure I2C high and low time
Configure the I2C bus high and low time for all enabled I2C buses.
BUG=b:168783630 TEST=Measured the I2C bus frequency reduce to 387 KHz.
Signed-off-by: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Change-Id: I37403dd3ac3c9320398207d2111e1ddb73d6a130 --- M src/mainboard/google/dedede/variants/boten/overridetree.cb 1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/48878/1
diff --git a/src/mainboard/google/dedede/variants/boten/overridetree.cb b/src/mainboard/google/dedede/variants/boten/overridetree.cb index ab8fcdb..e4f5e7b 100644 --- a/src/mainboard/google/dedede/variants/boten/overridetree.cb +++ b/src/mainboard/google/dedede/variants/boten/overridetree.cb @@ -21,15 +21,33 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 190, + .scl_hcnt = 100, + .sda_hold = 40, + } }, .i2c[1] = { .speed = I2C_SPEED_FAST, }, .i2c[2] = { .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 190, + .scl_hcnt = 100, + .sda_hold = 40, + } }, .i2c[4] = { .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 190, + .scl_hcnt = 100, + .sda_hold = 40, + } }, .i2c[5] = { .speed = I2C_SPEED_FAST,
Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48878 )
Change subject: mb/google/dedede/var/boten: Configure I2C high and low time ......................................................................
Patch Set 1:
Adding Karthik and Paul as reviewer. Thanks!
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48878 )
Change subject: mb/google/dedede/var/boten: Configure I2C high and low time ......................................................................
Patch Set 1: Code-Review+2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48878 )
Change subject: mb/google/dedede/var/boten: Configure I2C high and low time ......................................................................
Patch Set 1: Code-Review+2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48878 )
Change subject: mb/google/dedede/var/boten: Configure I2C high and low time ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48878 )
Change subject: mb/google/dedede/var/boten: Configure I2C high and low time ......................................................................
mb/google/dedede/var/boten: Configure I2C high and low time
Configure the I2C bus high and low time for all enabled I2C buses.
BUG=b:168783630 TEST=Measured the I2C bus frequency reduce to 387 KHz.
Signed-off-by: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Change-Id: I37403dd3ac3c9320398207d2111e1ddb73d6a130 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48878 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marco Chen marcochen@google.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/boten/overridetree.cb 1 file changed, 18 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Marco Chen: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved Paul Fagerburg: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/boten/overridetree.cb b/src/mainboard/google/dedede/variants/boten/overridetree.cb index ab8fcdb..e4f5e7b 100644 --- a/src/mainboard/google/dedede/variants/boten/overridetree.cb +++ b/src/mainboard/google/dedede/variants/boten/overridetree.cb @@ -21,15 +21,33 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 190, + .scl_hcnt = 100, + .sda_hold = 40, + } }, .i2c[1] = { .speed = I2C_SPEED_FAST, }, .i2c[2] = { .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 190, + .scl_hcnt = 100, + .sda_hold = 40, + } }, .i2c[4] = { .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 190, + .scl_hcnt = 100, + .sda_hold = 40, + } }, .i2c[5] = { .speed = I2C_SPEED_FAST,