[XS] Change in coreboot[main]: [MTL-x64]arch/x86: Update X86_64 memcpy for 4 byte copy

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81959?usp=email )

Change subject: [MTL-x64]arch/x86: Update X86_64 memcpy for 4 byte copy
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3:
> In current implementation fast_spi uses memcpy() and it is clear that the change in memcpy() broke it.
> We can make memcpy() to any no. of bytes, but it shouldn't break existing code that depend on memcpy() and cause regression on existing platforms. Also saying using memcpy() is "wrong" is wrong. It's a valid approach.

It's really not a valid approach to rely on specific internals of memcpy if your hardware specifically needs 32bit MMIO. And your "shouldn't break existing code" is also inappropriate: that fast_spi code is wrong, not memcpy...



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/81959?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1110cc18f5aa59c864e3cc04b9e6b3501ec4d54d
Gerrit-Change-Number: 81959
Gerrit-PatchSet: 3
Gerrit-Owner: Ashish Kumar Mishra <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Jérémy Compostella <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Saurabh Mishra <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Wed, 24 Apr 2024 12:13:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ashish Kumar Mishra <[e-mail]>
Gerrit-MessageType: comment