Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36341 )
Change subject: security/vboot: Build vboot library with same .a that depthcharge uses ......................................................................
Patch Set 3:
(1 comment)
Aww crap, we're running into problems with the TLCL stuff. Hmm. So I guess we somehow need two libraries after all for the time being.
We could either create a "vboot with TLCL" and "vboot without TLCL" library and link the former into depthcharge and the latter into coreboot. Or we create a "vboot" and a separate "tlcl" library, and have depthcharge explicitly link both of them. The latter approach seems a bit cleaner to me.
https://review.coreboot.org/c/coreboot/+/36341/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36341/1//COMMIT_MSG@9 PS1, Line 9: Switch from fwlib20 to fwlib
No, vboot_reference is a in a weird spot right now w/r/t ver1 / 2.0 / 2.1, etc. […]
Essentially, there is no two separate vboot APIs (all the vboot1 firmware verification stuff has long since been deleted). We have a single library where naming conventions have been moved to vb2_snake_case in some parts but not yet in others. vboot_fw20.a is just a weird half-library that only contains some of the pieces right now (whereas vboot_fw.a contains all of them), and I think that's dumb and we should fix that. It's a library so we're only using the things from it that we reference anyway, it's easier to just link the whole thing.