Attention is currently required from: CoolStar, Kyösti Mälkki, Sean Rhodes, Tim Crawford.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76382?usp=email )
Change subject: soc/intel/common: Restore to page 0 before reading SPD
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/smbus/smbuslib.c:
https://review.coreboot.org/c/coreboot/+/76382/comment/aef5c5d9_79dfffdc :
PS3, Line 44: smbus_write_byte(SPD_PAGE_0, 0, 0);
This part of the conditional should not evaluate true with DDR3 or older DIMMs: […]
since we can't know the DRAM type ahead of time, how about only restoring to page 0 in the event the read fails (==0) and then retrying the read? If we've already failed once, the timeout is less of an issue since we're likely failing to boot anyway
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76382?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad0a2024bd0ef39f6ab57ff7a6e6aa651d7882a6
Gerrit-Change-Number: 76382
Gerrit-PatchSet: 3
Gerrit-Owner: CoolStar
coolstarorganization@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: CoolStar
coolstarorganization@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 10 Jul 2023 16:44:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: CoolStar
coolstarorganization@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment