Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84605?usp=email )
Change subject: drivers/tpm: Remove unused 2nd argument in FUNC method ......................................................................
drivers/tpm: Remove unused 2nd argument in FUNC method
The method "FUNC" allows 1 argument, so remove the incorrectly referenced and unused second arguemnt.
This fixes: ToInteger (Arg1, Local1) Error 6006 - ^ Method argument is not initialized (Arg1)
Change-Id: If5e402579a2caff169e12253e5d9c2c493902ec7 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/84605 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michał Kopeć michal.kopec@3mdeb.com Reviewed-by: Nicholas Sudsgaard devel+coreboot@nsudsgaard.com --- M src/drivers/tpm/ppi.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: Nicholas Sudsgaard: Looks good to me, approved build bot (Jenkins): Verified Michał Kopeć: Looks good to me, approved
diff --git a/src/drivers/tpm/ppi.c b/src/drivers/tpm/ppi.c index 2ce1d07..68923ea 100644 --- a/src/drivers/tpm/ppi.c +++ b/src/drivers/tpm/ppi.c @@ -634,7 +634,6 @@ acpigen_write_method_serialized("FUNC", 1);
acpigen_write_to_integer(ARG0_OP, LOCAL0_OP); - acpigen_write_to_integer(ARG1_OP, LOCAL1_OP); acpigen_write_if(); acpigen_emit_byte(LGREATER_OP); acpigen_emit_byte(LOCAL0_OP);