Change in coreboot[master]: device: Prevent using `mmconf_resource` with invalid values - coreboot-gerrit

28 Jan 2021


      Attention is currently required from: Nico Huber, Tim Wawrzynczak, Angel Pons, Arthur Heymans, Evgeny Zinoviev, Kyösti Mälkki, Patrick Rudolph.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49744 )
Change subject: device: Prevent using `mmconf_resource` with invalid values
......................................................................
Patch Set 2:
(1 comment)
File src/device/device_util.c:
https://review.coreboot.org/c/coreboot/+/49744/comment/1e376b8c_c4138098 
PS2, Line 881: CONFIG_MMCONF_BASE_ADDRESS <= 0
can the hex numbers in kconfig hex options be negative? int can also be negative, but i'm not sure about hex
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49744
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4473268016ed511aa5c4930a71977e722e34162a
Gerrit-Change-Number: 49744
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Evgeny Zinoviev me@ch1p.io
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Thu, 28 Jan 2021 20:42:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment