[L] Change in coreboot[main]: mb/hp: Move compaq_8200_elite_sff_pc into snb_ivb_desktops variants

[Keith Hui (Code Review)]

Attention is currently required from: Felix Singer, Keith Hui, Riku Viitanen.

Keith Hui has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/79545?usp=email )

Change subject: mb/hp: Move compaq_8200_elite_sff_pc into snb_ivb_desktops variants
......................................................................


Patch Set 2:

(1 comment)

File src/mainboard/hp/snb_ivb_desktops/variants/compaq_8200_elite_sff/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/79545/comment/fce920af_a738996b?usp... :
PS2, Line 9: 			register "spi_uvscc" = "0x0"
> This isn't my (auto)port at all. The original port merged in CB:25385 is the source of this line. […]
> You tested to still boot, so looks like you have the hardware. Can you use iomem=relaxed with vendor firmware and confirm this item?

If I were you I would fix it here.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/79545?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I03d57c7e76ccdfccd58b2a6deab4dee87b02503a
Gerrit-Change-Number: 79545
Gerrit-PatchSet: 2
Gerrit-Owner: Riku Viitanen <[e-mail]>
Gerrit-Reviewer: Keith Hui <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Felix Singer <[e-mail]>
Gerrit-CC: Keith Hui <[e-mail]>
Gerrit-Attention: Riku Viitanen <[e-mail]>
Gerrit-Attention: Felix Singer <[e-mail]>
Gerrit-Attention: Keith Hui <[e-mail]>
Gerrit-Comment-Date: Sun, 04 Aug 2024 21:46:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Riku Viitanen <[e-mail]>
Comment-In-Reply-To: Keith Hui <[e-mail]>