Attention is currently required from: Arthur Heymans, Felix Held.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76515?usp=email )
Change subject: vendorcode/amd/opensil: Add initial setup and API calls ......................................................................
Patch Set 7:
(2 comments)
File src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h:
https://review.coreboot.org/c/coreboot/+/76515/comment/f7d95965_eae99a81 : PS6, Line 7:
might be good to do the whitespace changes in a separate patch. […]
Done
File src/vendorcode/amd/opensil/genoa_poc/ramstage.c:
https://review.coreboot.org/c/coreboot/+/76515/comment/0fe020cb_857ae490 : PS6, Line 86: BOOT_STATE_INIT_ENTRY(BS_DEV_INIT_CHIPS, BS_ON_EXIT, opensil_entry, (void *)SIL_TP1);
we should probably look into removing the BOOT_STATE_INIT_ENTRY in this file and have the few calls […]
Done