[S] Change in coreboot[master]: mb/google/nissa/var/xivu: Change TPM I2C freqeuncy to 1 MHz - coreboot-gerrit

6 Oct 2022


      Attention is currently required from: Ian Feng, Kangheui Won, Shou-Chieh Hsu.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68071 )
Change subject: mb/google/nissa/var/xivu: Change TPM I2C freqeuncy to 1 MHz
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Patchset:
PS2: 
You need to add configs for all the buses, not just I2C0. Otherwise the other buses will default to rise/fall time 0, which will give the wrong frequency.
Could you please add configs for the other buses, take measurements on all of them and attach the results to the bug?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/68071
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33f712c14978b95f3a4da82d6f1f5fbae1283b17
Gerrit-Change-Number: 68071
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Feng ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Frank Wu frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Reka Norman rekanorman@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu shouchieh@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Amanda Hwang amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: EricKY Cheng ericky_cheng@compal.corp-partner.google.com
Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com
Gerrit-Attention: Ian Feng ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Kangheui Won khwon@chromium.org
Gerrit-Attention: Shou-Chieh Hsu shouchieh@google.com
Gerrit-Comment-Date: Thu, 06 Oct 2022 22:45:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment