[L] Change in coreboot[main]: mb: Enable VBOOT_LID_SWITCH by default
Attention is currently required from: Alexander Couzens, Christian Walter, Eran Mitrani, Erik van den Bogaert, Felix Held, Frans Hendriks, Fred Reitberger, Hung-Te Lin, Jakub Czapiga, Jason Glenesk, Jason Nien, Julius Werner, Kapil Porwal, Martin Roth, Michael Niewöhner, Michał Kopeć, Michał Żygowski, Nick Vaccaro, Patrick Rudolph, Piotr Król, Sean Rhodes, Stefan Ott, Tarun, Werner Zeh, Yidi Lin, Yu-Ping Wu. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78207?usp=email ) Change subject: mb: Enable VBOOT_LID_SWITCH by default ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/corsola/Kconfig: https://review.coreboot.org/c/coreboot/+/78207/comment/1a93b0e8_fabac018 : PS3, Line 51: config VBOOT_LID_SWITCH : default n
I think corsola (and many other ARM boards) does have a LID switch - it's just that we usually copy from the previous platform and didn't know there are new options to turn on.
I'm concerned that this CL enabling VBOOT_LID_SWITCH config may change the existing behavior of the platform that intentionally or unintentionally ignore VBOOT_LID_SWITCH earlier. Would you mind adding VBOOT_LID_SWITCH for the required platform in subsequent CL? WDYT?
@yupingso is it safe to turn on VBOOT_LID_SWITCH? can you check?
-- To view, visit https://review.coreboot.org/c/coreboot/+/78207?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I922c04e0fa0675090cea7c7b3f4e2275eb70f523 Gerrit-Change-Number: 78207 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik@google.com> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com> Gerrit-Reviewer: Eran Mitrani <mitrani@google.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert@eltan.com> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred@gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Jakub Czapiga <jacz@semihalf.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien@amd.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com> Gerrit-Reviewer: Martin Roth <martin.roth@amd.corp-partner.google.com> Gerrit-Reviewer: Michael Niewöhner <foss@mniewoehner.de> Gerrit-Reviewer: Michał Kopeć <michal.kopec@3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Piotr Król <piotr.krol@3mdeb.com> Gerrit-Reviewer: Sean Rhodes <sean@starlabs.systems> Gerrit-Reviewer: Stefan Ott <coreboot@desire.ch> Gerrit-Reviewer: Tarun <tstuli@gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: Yidi Lin <yidilin@google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte@chromium.org> Gerrit-Attention: Stefan Ott <coreboot@desire.ch> Gerrit-Attention: Eran Mitrani <mitrani@google.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Attention: Jakub Czapiga <jacz@semihalf.com> Gerrit-Attention: Nick Vaccaro <nvaccaro@chromium.org> Gerrit-Attention: Yidi Lin <yidilin@google.com> Gerrit-Attention: Piotr Król <piotr.krol@3mdeb.com> Gerrit-Attention: Sean Rhodes <sean@starlabs.systems> Gerrit-Attention: Michał Żygowski <michal.zygowski@3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter@9elements.com> Gerrit-Attention: Michał Kopeć <michal.kopec@3mdeb.com> Gerrit-Attention: Fred Reitberger <reitbergerfred@gmail.com> Gerrit-Attention: Werner Zeh <werner.zeh@siemens.com> Gerrit-Attention: Alexander Couzens <lynxis@fe80.eu> Gerrit-Attention: Yu-Ping Wu <yupingso@google.com> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-Attention: Frans Hendriks <fhendriks@eltan.com> Gerrit-Attention: Jason Nien <jason.nien@amd.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner@chromium.org> Gerrit-Attention: Michael Niewöhner <foss@mniewoehner.de> Gerrit-Attention: Martin Roth <martin.roth@amd.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli@gmail.com> Gerrit-Attention: Erik van den Bogaert <ebogaert@eltan.com> Gerrit-Attention: Jason Glenesk <jason.glenesk@gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal@google.com> Gerrit-Comment-Date: Mon, 02 Oct 2023 04:22:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte@chromium.org> Gerrit-MessageType: comment
participants (1)
-
Subrata Banik (Code Review)